-
Notifications
You must be signed in to change notification settings - Fork 39
Feature: Pre-Install VS Code extensions in desktop VS Code module #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Pre-Install VS Code extensions in desktop VS Code module #218
Conversation
@matifali can you please review the PR |
…oder/registry into feature/pre-install
if [ -x "$path" ]; then | ||
export PATH="$PATH:$(dirname "$path")" | ||
return 0 | ||
fi | ||
done | ||
|
||
# Try to install VS Code Desktop (which provides the CLI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashksaini-coder Another option is to not install the code CLI at all and direct download and place extensions VSIX files in the --extensions-dir
directory.
We can take that as input to the moudle with a sane default.
Additionally, downloading extensions directly would work with Other VSCode-based IDEs, such as Cursor, WindSurf, and Kiro.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install the CLI instead of full VSCode
https://code.visualstudio.com/download
@matifali understood let me work on this |
Hey @yashksaini-coder - can you please submit a video of this working in a coder deployment once those fixes are made? |
I'm on windows and have performing testing on my code. Haven't been able to deploy properly |
/claim #207
Closes #207
Description
setup.sh
script to install extensions & settings managementThis pull request introduces functionality to automate the setup of Visual Studio Code (VS Code) workspaces, including the installation of extensions and configuration of workspace settings. It adds new Terraform variables and resources, a setup script, and corresponding tests to ensure proper behavior.
Terraform Module Enhancements:
extensions
,settings
, andinstall_extensions
variables to allow users to specify VS Code extensions, workspace settings, and control automatic installation behavior. Validation ensures proper formatting for extensions. (registry/coder/modules/vscode-desktop/main.tf
, registry/coder/modules/vscode-desktop/main.tfR41-R85)coder_script
resource that dynamically creates a setup script to install extensions and configure settings when applicable. (registry/coder/modules/vscode-desktop/main.tf
, registry/coder/modules/vscode-desktop/main.tfR41-R85)Setup Script:
setup.sh
) to handle the installation of extensions, configuration of workspace settings, and creation of extension recommendations. The script includes robust error handling, logging, and validation mechanisms. (registry/coder/modules/vscode-desktop/setup.sh
, registry/coder/modules/vscode-desktop/setup.shR1-R267)Documentation Updates:
README.md
to include examples for auto-installing extensions, configuring settings, and disabling automatic installation. (registry/coder/modules/vscode-desktop/README.md
, registry/coder/modules/vscode-desktop/README.mdR38-R77)Testing:
install_extensions
flag. (registry/coder/modules/vscode-desktop/main.test.ts
, registry/coder/modules/vscode-desktop/main.test.tsR89-R143)Type of Change
Module Information
Path:
registry/coder/modules/vscode-desktop
New version:
v1.0.0
Breaking change: [ ] Yes [X] No
Testing & Validation
bun test
)bun run fmt
)Related Issues
None